Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix dark mode small issues #7573

Merged
merged 3 commits into from
Nov 1, 2023
Merged

fix: Fix dark mode small issues #7573

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66dc33f
fix: fix stikcy color
mutdmour Nov 1, 2023
16d3602
fix: collection param fix
mutdmour Nov 1, 2023
07ad081
fix: fix dots on theme change
mutdmour Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/design-system/src/components/N8nMarkdown/Markdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export default defineComponent({
}

code {
background-color: var(--color-background-base);
background-color: var(--color-sticky-code-background);
padding: 0 var(--spacing-4xs);
color: var(--color-secondary);
}
Expand Down
3 changes: 3 additions & 0 deletions packages/design-system/src/css/_tokens.dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
--color-canvas-selected: var(--prim-gray-0-alpha-025);
--node-type-main-color: var(--prim-gray-420);

// Sticky
--color-sticky-code-background: var(--color-background-light);
Copy link
Member

@netroy netroy Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contrast on this is not good.
image

Not sure if --color-secondary needs to be brighter in dark mode, or if we need to define a new --color-sticky-code-foreground variable.

Copy link
Contributor Author

@mutdmour mutdmour Nov 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya it's not perfect.. but to unblock this


// Expressions
--color-valid-resolvable-foreground: var(--prim-color-alt-a-tint-300);
--color-valid-resolvable-background: var(--prim-color-alt-a-alpha-025);
Expand Down
1 change: 1 addition & 0 deletions packages/design-system/src/css/_tokens.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
--color-sticky-default-background: var(--prim-color-alt-d);
--color-sticky-default-border: var(--prim-color-alt-d-shade-150);
--color-sticky-font: var(--prim-gray-740);
--color-sticky-code-background: var(--color-background-base);

// Expressions
--color-valid-resolvable-foreground: var(--prim-color-alt-a);
Expand Down
1 change: 1 addition & 0 deletions packages/editor-ui/src/components/CollectionParameter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ export default defineComponent({
margin-top: var(--spacing-xs);

.button {
color: var(--color-text-dark);
font-weight: var(--font-weight-normal);
--button-border-color: var(--color-foreground-base);
--button-background-color: var(--color-background-base);
Expand Down
Loading