Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Fix some UTM tags (no-changelog) #7583

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

krynble
Copy link
Contributor

@krynble krynble commented Nov 2, 2023

Github issue / Community forum post (link here to close automatically):

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (437c95e) 33.74% compared to head (374b291) 33.74%.
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7583      +/-   ##
==========================================
- Coverage   33.74%   33.74%   -0.01%     
==========================================
  Files        3408     3409       +1     
  Lines      208583   208661      +78     
  Branches    22562    22562              
==========================================
+ Hits        70391    70403      +12     
- Misses     137044   137107      +63     
- Partials     1148     1151       +3     
Files Coverage Δ
packages/cli/src/Ldap/helpers.ts 83.92% <100.00%> (+0.19%) ⬆️
packages/cli/src/auth/methods/email.ts 80.00% <50.00%> (+22.85%) ⬆️
...src/components/CredentialEdit/CredentialConfig.vue 0.00% <0.00%> (ø)
packages/editor-ui/src/components/MainSidebar.vue 47.15% <0.00%> (ø)
packages/cli/src/controllers/auth.controller.ts 75.86% <40.00%> (-1.82%) ⬇️

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krynble krynble changed the title feat(editor): Adding discord link and fixing some UTM tags feat(editor): Fix some UTM tags (no-changelog) Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 3, 2023

3 flaky tests on run #2714 ↗︎

0 263 0 0 Flakiness 3

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 krynble 🗃️ e2e/*
Project: n8n Commit: 374b291ac2
Status: Passed Duration: 06:57 💡
Started: Nov 3, 2023 11:15 AM Ended: Nov 3, 2023 11:21 AM
Flakiness  12-canvas.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Node Manipulation and Navigation > should add nodes and check execution success Output Screenshots Video
Flakiness  6-code-node.cy.ts • 1 flaky test

View Output Video

Test Artifacts
... > generate code button should have correct state & tooltips Output Screenshots Video
Flakiness  28-resource-mapper.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Resource Mapper > should correctly delete single field Output Screenshots Video

Review all test suite changes for PR #7583 ↗︎

@krynble krynble merged commit c6049a2 into master Nov 3, 2023
56 of 57 checks passed
@krynble krynble deleted the add-discord-link branch November 3, 2023 15:17
MiloradFilipovic added a commit that referenced this pull request Nov 3, 2023
* master:
  feat(editor): Fix some UTM tags (no-changelog) (#7583)
  feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) (#7567)
  fix(editor): Zoom in/out on canvas the same amount on scroll/gesture (#7602)
@janober
Copy link
Member

janober commented Nov 8, 2023

Got released with n8n@1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants