Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Stop disabling linting rules that are explicitly set to warn (no-changelog) #7669

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 9, 2023

No description provided.

@netroy netroy changed the title ci (core): Stop disabling linting rules that are explicitly set to warn (no-changelog) ci: Stop disabling linting rules that are explicitly set to warn (no-changelog) Nov 9, 2023
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 9, 2023
Copy link
Contributor

github-actions bot commented Nov 9, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 9, 2023

2 flaky tests on run #2804 ↗︎

0 272 3 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 2a9b3400ba
Status: Passed Duration: 07:53 💡
Started: Nov 9, 2023 12:38 PM Ended: Nov 9, 2023 12:46 PM
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View
Output
Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Screenshots Video
Flakiness  28-resource-mapper.cy.ts • 1 flaky test

View
Output
Video

Test Artifacts
Resource Mapper > should correctly delete single field Screenshots Video

Review all test suite changes for PR #7669 ↗︎

Copy link
Contributor

github-actions bot commented Nov 9, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 5edf722 into master Nov 9, 2023
56 of 57 checks passed
@netroy netroy deleted the stop-disabling-warn-rules branch November 9, 2023 13:05
@janober
Copy link
Member

janober commented Nov 15, 2023

Got released with n8n@1.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants