Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): Refactor nodeHelpers mixin to composable #7810

Merged
merged 14 commits into from
Dec 8, 2023

Conversation

OlegIvaniv
Copy link
Contributor

@OlegIvaniv OlegIvaniv commented Nov 24, 2023

  • Convert nodeHelpers mixin into composable and fix types
  • Replace usage of the mixin with the new composable
  • Add missing store imports in components that were dependent on opaque imports from nodeHelpers mixin
  • Refactor the CollectionParameter component to the modern script setup syntax
    Github issue / Community forum post (link here to close automatically):

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 24, 2023
Copy link

cypress bot commented Nov 24, 2023

Passing run #3279 ↗︎

0 294 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: 3cc4d79395
Status: Passed Duration: 06:30 💡
Started: Dec 8, 2023 3:52 PM Ended: Dec 8, 2023 3:58 PM

Review all test suite changes for PR #7810 ↗︎

cstuncsik
cstuncsik previously approved these changes Dec 8, 2023
Copy link
Contributor

github-actions bot commented Dec 8, 2023

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Copy link
Contributor

github-actions bot commented Dec 8, 2023

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 35fbc37 into master Dec 8, 2023
32 checks passed
@OlegIvaniv OlegIvaniv deleted the n8n-7058-tech-debt-refactor-nodehelpers-mixin branch December 8, 2023 15:59
@janober
Copy link
Member

janober commented Dec 13, 2023

Got released with n8n@1.21.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants