refactor(core): Reorganize error hierarchy in cli package (no-changelog)
#7839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Nov 28, 2023
n8n-assistant
bot
added
core
Passing run #3060 ↗︎
Details:
Review all test suite changes for PR #7839 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
rishikeshjoshi
pushed a commit
to rishikeshjoshi/n8n
that referenced
this pull request
Nov 28, 2023
…elog) (n8n-io#7839) Ensure all errors in `cli` inherit from `ApplicationError` to continue normalizing all the errors we report to Sentry Follow-up to: n8n-io#7820
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 29, 2023
* master: fix(editor): Add telemetry to workflow history (#7811) fix(editor): Fix mouse position in workflow previews (#7853) fix(editor): Fix icon for unknown node type (#7842) ci: Fix editor tests when coverage is enabled (no-changelog) (#7827) fix(editor): Suppress dev server websocket messages in workflow view (#7808) feat(core): Update LLM applications building support (no-changelog) (#7710) fix(editor): Fix push connection on WorkerList and CommunityNodes pages (no-changelog) (#7851) fix(editor): Remove ability for users to select admin role in the UI (no-changelog) (#7850) feat(core): Set up endpoint for all existing roles with license flag (#7834) fix(editor): Fix credential icon for old node type version (#7843) feat: Add initial scope checks via decorators (#7737) refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) (#7838) fix(editor): Allow owners and admins to share workflows and credentials they don't own (#7833) refactor(core): Reorganize error hierarchy in `cli` package (no-changelog) (#7839) fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working (#7832) fix(Google Sheets Node): Read operation execute for each item (#7800) fix(core): Node version in the user added node to workflow canvas event (no-changelog) (#7814)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure all errors in
cliinherit fromApplicationErrorto continue normalizing all the errors we report to SentryFollow-up to: #7820