Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Separate API response from error in execution error causes (no-changelog) #7880

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 30, 2023

Store the third-party API response error separately from the error stored as cause

Follow-up to: #7820 (comment)

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Nov 30, 2023
@netroy
Copy link
Member

netroy commented Nov 30, 2023

Started workflow tests for this branch. when they pass, we can merge this 🙏🏽

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Nov 30, 2023

Passing run #3137 ↗︎

0 295 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 3017eb9f60
Status: Passed Duration: 06:26 💡
Started: Nov 30, 2023 11:54 AM Ended: Nov 30, 2023 12:01 PM

Review all test suite changes for PR #7880 ↗︎

@ivov ivov merged commit e0b7f89 into master Nov 30, 2023
20 checks passed
@ivov ivov deleted the separate-api-response-from-error-execution-error-causes branch November 30, 2023 13:44
@janober
Copy link
Member

janober commented Dec 6, 2023

Got released with n8n@1.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants