Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add missing workflow id from route (no-changelog) #7918

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

alexgrozav
Copy link
Contributor

Summary

Fixes missing workflow id from route.

How to test the change:

  1. Go to executions page for a workflow without executions
  2. Wait for autoRefresh to start
  3. Error appears in console due to missing name parameter

Issues fixed

Include links to Github issue or Community forum post or Linear ticket:

Important in order to close automatically and provide context to reviewers

https://linear.app/n8n/issue/N8N-7075/error-missing-required-param-name

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

    (internal) You can use Slack commands to trigger e2e tests or deploy test instance or deploy early access version on Cloud.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 4, 2023
@alexgrozav alexgrozav changed the title fix(editor): Add missing workflow id from route fix(editor): Add missing workflow id from route (no-changelog) Dec 4, 2023
@alexgrozav alexgrozav self-assigned this Dec 4, 2023
Copy link

cypress bot commented Dec 5, 2023

Passing run #3188 ↗︎

0 297 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project: n8n Commit: be5f4920c8
Status: Passed Duration: 06:32 💡
Started: Dec 5, 2023 8:33 AM Ended: Dec 5, 2023 8:39 AM

Review all test suite changes for PR #7918 ↗︎

Copy link
Contributor

github-actions bot commented Dec 5, 2023

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit 0a745d1 into master Dec 5, 2023
20 checks passed
@alexgrozav alexgrozav deleted the n8n-7075-error-missing-required-param-name branch December 5, 2023 08:43
@janober
Copy link
Member

janober commented Dec 6, 2023

Got released with n8n@1.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants