Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(editor): Add telemetry for log streaming (no-changelog) #8075

Merged
merged 2 commits into from
Dec 19, 2023
Merged

refactor(editor): Add telemetry for log streaming (no-changelog) #8075

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d43a04c
refactor(editor): Add telemetry for log streaming (no-changelog)
ivov Dec 18, 2023
38b3a6d
Add line breaks
ivov Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/editor-ui/src/components/SettingsLogStreaming/EventDestinationSettingsModal.ee.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ import SaveButton from '@/components/SaveButton.vue';
import EventSelection from '@/components/SettingsLogStreaming/EventSelection.ee.vue';
import type { EventBus } from 'n8n-design-system';
import { createEventBus } from 'n8n-design-system/utils';
import { useTelemetry } from '@/composables/useTelemetry';
import { useRootStore } from '@/stores/n8nRoot.store';

export default defineComponent({
name: 'event-destination-settings-modal',
Expand Down Expand Up @@ -471,6 +473,34 @@ export default defineComponent({
this.unchanged = true;
this.eventBus.emit('destinationWasSaved', this.destination.id);
this.uiStore.stateIsDirty = false;

const destinationType = (this.nodeParameters.__type ?? 'unknown')
.replace('$$MessageEventBusDestination', '')
.toLowerCase();

const isComplete = () => {
if (this.isTypeWebhook) {
return this.destination.host !== '';
} else if (this.isTypeSentry) {
return this.destination.dsn !== '';
} else if (this.isTypeSyslog) {
return (
this.destination.host !== '' &&
this.destination.port !== undefined &&
this.destination.protocol !== '' &&
this.destination.facility !== undefined &&
this.destination.app_name !== ''
);
}
return false;
};

useTelemetry().track('User updated log streaming destination', {
instance_id: useRootStore().instanceId,
destination_type: destinationType,
is_complete: isComplete(),
is_active: this.destination.enabled,
});
}
},
},
Expand Down
Loading