fix: Add template id to workflows created from templates (no-changelog) #8226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
mutdmour
reviewed
Jan 4, 2024
mutdmour
previously approved these changes
Jan 4, 2024
|
|
2 flaky tests on run #3602 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Screenshots
Video
|
|
26-resource-locator.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Resource Locator > should retrieve list options when other params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #8226 ↗︎
|
✅ All Cypress E2E specs passed |
tomi
force-pushed
the
ado-1639-bug-connect-wf-with-template
branch
from
d40b4e2
to
b986263
Compare
mutdmour
approved these changes
Jan 5, 2024
|
✅ All Cypress E2E specs passed |
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #8088 template ID was added to workflow metadata, but it was missing from workflows that were created using the template credential setup. This fixes that.
Related tickets and issues
https://linear.app/n8n/issue/ADO-1639/bug-connect-wf-with-template
Review / Merge checklist
(no-changelog)otherwise. (conventions)