fix(core): Avoid wrapping ExecutionBaseError to prevent misreporting to Sentry (no-changelog)
#8262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to Sentry (no-changelog) `requestWithAuthentication` has calls that may throw `NodeOperationError` but we are wrapping those errors in `NodeApiError`, which is causing those errors to be reported to Sentry even when they are level `warning`. Ref: https://n8nio.sentry.io/issues/4833348705
n8n-assistant
bot
added
core
netroy
previously approved these changes
Jan 8, 2024
netroy
reviewed
Jan 8, 2024
| @@ -1805,6 +1805,8 @@ export async function requestWithAuthentication( | |||
| } | |||
| throw error; | |||
| } catch (error) { | |||
| if (error instanceof NodeOperationError) throw error; | |||
There was a problem hiding this comment.
should we check for ExecutionBaseError instead ?
ivov
changed the title
NodeOperationError to prevent misreporting to Sentry (no-changelog)ExecutionBaseError to prevent misreporting to Sentry (no-changelog)
netroy
approved these changes
Jan 9, 2024
3 flaky tests on run #3657 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Screenshots
Video
|
|
27-two-factor-authentication.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Two-factor authentication > Should be able to login with MFA token |
Screenshots
Video
|
|
Review all test suite changes for PR #8262 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 10, 2024
* master: ci: Validate docs urls for langchain nodes as well (no-changelog) (#8271) fix: Small ui fixes to workflow cred setup modal (no-changelog) (#8280) fix: Fix issue with API key being required for the Qdrant Node (#8237) feat(Coda Node): Add User-Agent for requests to Coda (no-changelog) (#7771) fix(FTP Node): FTP connection failed due to missing password credential in node (#8131) ci: Fix lint setup in `chat` package (no-changelog) (#8275) ci: Fix codecov reporting, and include all packages (no-changelog) (#8276) fix(core): Fix test webhook deregistration (#8247) docs: Update links in deprecated langchain nodes to avoid linting errors (no-changelog) (#8273) fix: Fix user reinvites on FE and BE (#8261) docs: Update primaryDocumentation urls for nodes updated in #7651 (no-changelog) (#8270) feat: Add Chat Trigger node (#7409) fix(Github Trigger Node): Enforce SSL validation by default (#8265) fix(editor): Tweaking button sizes in execution preview (#8206) fix(core): Avoid wrapping `ExecutionBaseError` to prevent misreporting to Sentry (no-changelog) (#8262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requestWithAuthenticationhas calls that may throwNodeOperationErrorbut we are wrapping those errors inNodeApiError, which is causing those errors to be reported to Sentry even when they are levelwarning.Ref: https://n8nio.sentry.io/issues/4833348705