fix(API): Fix manual chat trigger execution #8300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
3 flaky tests on run #3715 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
29-templates.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Templates > should save template id with the workflow |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8300 ↗︎
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
OlegIvaniv
force-pushed
the
fix_chat_debug_exec
branch
from
cb392dd
to
ef5409f
Compare
OlegIvaniv
changed the title
OlegIvaniv
changed the title
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
alexgrozav
approved these changes
Jan 11, 2024
|
✅ All Cypress E2E specs passed |
netroy
pushed a commit
that referenced
this pull request
Jan 16, 2024
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to wrongly resolved merge conflict, the
needsWebhookfunction incorrectly returnstruefor manual chat trigger execution. To fix this, we need to pass the runData and check if webhook runData is already set.