fix(core): Replace all moment imports with moment-timezone
#8337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joffcom
approved these changes
Jan 15, 2024
n8n-assistant
bot
added
n8n team
|
Closes #8336 |
1 flaky test on run #3763 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8337 ↗︎
|
✅ All Cypress E2E specs passed |
|
Got released with |
|
This is so great. Thank you all so much!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of nodes code imports
momentand then usesmoment.tz, which only works if somewhere else in the code we have already loadedmoment-timezone.But sometimes
moment.tzgets called beforemoment-timezonehas been imported.As we decouple and lazy-load more code, stuff like this is a lot more likely to happen.
That's why I've removed
momentas a direct dependency, and hopefullyimport/no-extraneous-dependencieswould prevent people from adding it back.Review / Merge checklist