feat: Nudge users to become template creators if eligible #8357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
reviewed
Jan 17, 2024
packages/cli/src/databases/repositories/workflowStatistics.repository.ts
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/BecomeTemplateCreatorCta/becomeTemplateCreatorStore.ts
Outdated
Show resolved
Hide resolved
packages/editor-ui/src/components/BecomeTemplateCreatorCta/becomeTemplateCreatorStore.ts
Show resolved
Hide resolved
packages/editor-ui/src/components/BecomeTemplateCreatorCta/becomeTemplateCreatorStore.ts
Show resolved
Hide resolved
packages/editor-ui/src/components/BecomeTemplateCreatorCta/BecomeTemplateCreatorCta.vue
Show resolved
Hide resolved
|
@ivov thank you for a thorough review 🙇 Addressed all feedback. Please have another look 🙏 |
ivov
previously approved these changes
Jan 17, 2024
| getBecomeTemplateCreatorCta().should('not.exist'); | ||
| }); | ||
|
|
||
| it('should show the CTA', () => { |
There was a problem hiding this comment.
Suggested change
| it('should show the CTA', () => { | |
| it('should show the CTA if the user is eligible', () => { |
packages/cli/src/databases/repositories/workflowStatistics.repository.ts
Outdated
Show resolved
Hide resolved
| @@ -98,4 +101,23 @@ export class WorkflowStatisticsRepository extends Repository<WorkflowStatistics> | |||
| throw error; | |||
| } | |||
| } | |||
|
|
|||
| async queryNumWorkflowsUserHasWith5OrMoreProdExecs(userId: User['id']): Promise<number> { | |||
There was a problem hiding this comment.
Renamed to be a bit clearer
Passing run #3808 ↗︎
Details:
Review all test suite changes for PR #8357 ↗︎ |
|||||||||||||||
|
|
ivov
approved these changes
Jan 17, 2024
|
✅ All Cypress E2E specs passed |
tomi
deleted the
ado-1669-feature-template-creator-cta-for-existing-users
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a CTA for users to become template creators. The CTA is shown for users who have at least 3 active workflows with each at least 5 successful production executions.
Kapture.2024-01-17.at.11.17.52.mp4
Related tickets and issues
https://linear.app/n8n/issue/ADO-1669/feature-template-creator-cta-for-existing-users
Review / Merge checklist
(no-changelog)otherwise. (conventions)