feat(core): Upgrade Rudderstack SDK to address CVE-2023-45857 #8368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
changed the title
n8n-assistant
bot
added
core
netroy
force-pushed
the
upgrade-rudderstack-sdk
branch
from
7a118b9
to
e7bc2ac
Compare
This helps remove some of the older versions of transient dependencies, like axios 0.x and ioredis 4.x.
netroy
force-pushed
the
upgrade-rudderstack-sdk
branch
from
e7bc2ac
to
cf1b4d5
Compare
netroy
commented
Jan 26, 2024
| axiosInstance, | ||
| logLevel, | ||
| dataPlaneUrl, | ||
| gzip: false, |
There was a problem hiding this comment.
unless we upgrade the dataplane to version 1.4 or above, gzipped payloads will cause 500s.
Since we haven't been gzipping telemetry payloads so far, this is not a blocker.
krynble
approved these changes
Jan 26, 2024
1 flaky test on run #3938 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8368 ↗︎
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps remove some of the older versions of transient dependencies, like axios 0.x and ioredis 4.x.
This needs some thorough testing before we can merge this.
Review / Merge checklist