fix: Force posthog recording to be disabled outside cloud #8374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
netroy
reviewed
Jan 17, 2024
tomi
force-pushed
the
ado-1659-make-it-harder-to-enable-posthog-session-recording
branch
from
c790ab7
to
5bb0acd
Compare
netroy
requested changes
Jan 18, 2024
The recordings are not enabled by default, but env variable enabled opt-in. This changes the logic that opt-in requires cloud deployment.
tomi
force-pushed
the
ado-1659-make-it-harder-to-enable-posthog-session-recording
branch
from
5bb0acd
to
2d680cf
Compare
netroy
approved these changes
Jan 18, 2024
Passing run #3815 ↗︎
Details:
Review all test suite changes for PR #8374 ↗︎ |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
tomi
deleted the
ado-1659-make-it-harder-to-enable-posthog-session-recording
branch
ivov
pushed a commit
that referenced
this pull request
Jan 22, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The recordings are not enabled by default, but env variable enables opt-in. This changes the logic that opt-in requires also being a cloud deployment.
Related tickets and issues
https://linear.app/n8n/issue/ADO-1659/self-hosted-data-bleeding-into-posthog
Review / Merge checklist
(no-changelog)otherwise. (conventions)