Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Missing pairedItem fixes #8394

Conversation

michael-radency
Copy link
Contributor

Summary

If you use the merge node and tell it to wait for both to finish and to output a single empty item you are no longer able to reference previous data

Related tickets and issues

https://community.n8n.io/t/issue-with-http-node-output-containing-error/35062
https://linear.app/n8n/issue/NODE-1049/merge-node-output-single-item-loses-paired-items

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Jan 19, 2024
@michael-radency michael-radency changed the title fix(Merge Node): Output Single Item loses paired items fix(nodes: Missing pairedItem fixes Jan 19, 2024
@michael-radency michael-radency changed the title fix(nodes: Missing pairedItem fixes fix(nodes): Missing pairedItem fixes Jan 19, 2024
@michael-radency michael-radency changed the title fix(nodes): Missing pairedItem fixes fix(core): Missing pairedItem fixes Jan 19, 2024
Copy link

cypress bot commented Jan 19, 2024

Passing run #3835 ↗︎

0 336 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project: n8n Commit: aaab501a7e
Status: Passed Duration: 03:20 💡
Started: Jan 19, 2024 11:42 AM Ended: Jan 19, 2024 11:45 AM

Review all test suite changes for PR #8394 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 284d965 into master Jan 19, 2024
29 of 31 checks passed
@michael-radency michael-radency deleted the node-1049-merge-node-output-single-item-loses-paired-items branch January 19, 2024 11:47
ivov pushed a commit that referenced this pull request Jan 22, 2024
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
@janober
Copy link
Member

janober commented Jan 22, 2024

Got released with n8n@1.25.1

@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants