Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Couple of refactors on WorkflowRunner and ActiveExecutions (no-changelog) #8487

Merged
merged 6 commits into from
Feb 6, 2024
Merged

refactor(core): Couple of refactors on WorkflowRunner and ActiveExecutions (no-changelog) #8487

merged 6 commits into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. remove initErrorHandling call from WorkflowRunner. it's not required

    @netroy
    netroy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f231100 View commit details
    Browse the repository at this point in the history

  2. we don't need to call Container.get(Queue) for every execution

    @netroy
    netroy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bc872fe View commit details
    Browse the repository at this point in the history

  3. ActiveExecutions.setStatus isn't async, and does not throw

    @netroy
    netroy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    fed06e6 View commit details
    Browse the repository at this point in the history

  4. delete code duplication in ActiveExecutions

    @netroy
    netroy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    39eba73 View commit details
    Browse the repository at this point in the history

  5. move active execution shutdown to ActiveExecutions

    @netroy
    netroy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    c2003ce View commit details
    Browse the repository at this point in the history

  6. save execution to DB before doing anything else 

    and, move execution creation into a single place
    @netroy
    netroy committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8f28c36 View commit details
    Browse the repository at this point in the history