Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initial Dev Containers setup (no-changelog) #8951

Merged
merged 2 commits into from
Jun 6, 2024
Merged

feat: Initial Dev Containers setup (no-changelog) #8951

merged 2 commits into from
Jun 6, 2024

Conversation

jeankhawand
Copy link
Contributor

@jeankhawand jeankhawand commented Mar 21, 2024 •
edited
Loading

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

This will enhance developer experience by offering a sandbox including all the steps mentioned in CONTRIBUTING.md
image

image
devcontainer-demo.mp4

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Note

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jeankhawand jeankhawand changed the title 🎉 Support DevContainer feat(dev-container): initial setup for dev container Mar 21, 2024
@n8n-assistant n8n-assistant bot added the community Authored by a community member label Mar 21, 2024
@Joffcom
Copy link
Member

Joffcom commented Apr 15, 2024

@netroy what do you think?

@netroy netroy changed the title feat(dev-container): initial setup for dev container feat: Initial Dev Containers setup (no-changelog) Jun 4, 2024
@netroy netroy merged commit f7198e3 into n8n-io:master Jun 6, 2024
10 of 11 checks passed
@netroy
Copy link
Member

netroy commented Jun 6, 2024

@jeankhawand Thanks a lot for your contribution 🙏🏽 💟

MiloradFilipovic added a commit that referenced this pull request Jun 6, 2024
@MiloradFilipovic
Merge branch 'master' into ado-2234-transparent-top-menu-in-cloud
59732b8 
* master:
  feat: Initial Dev Containers setup (no-changelog) (#8951)
  feat: Add support for dark mode node icons and colors (#9412)
  fix(Gotify Node): Fix issue with self signed certificates not working (#9647)
  refactor(core): Support writing tests in `cli/src` (no-changelog) (#9646)
  fix(n8n Form Trigger Node): Error if Respond to Webhook and respond node not in workflow (#9641)
RicardoE105 pushed a commit that referenced this pull request Jun 9, 2024
@jeankhawand @netroy @RicardoE105
feat: Initial Dev Containers setup (no-changelog) (#8951)
e1fafdd 
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
@janober
Copy link
Member

janober commented Jun 12, 2024

Got released with n8n@1.46.0

@netroy netroy mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

@despairblue despairblue despairblue approved these changes

Assignees
No one assigned
Labels
community Authored by a community member Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeankhawand @CLAassistant @Joffcom @netroy @janober @despairblue