-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Delete some duplicate code in cli tests (no-changelog) #9049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Enhancement outside /nodes-base and /editor-ui
n8n team
Authored by the n8n team
labels
Apr 3, 2024
ivov
reviewed
Apr 5, 2024
ivov
previously approved these changes
Apr 5, 2024
|
Passing run #4591 ↗︎
Details:
Review all test suite changes for PR #9049 ↗︎ |
ivov
approved these changes
Apr 5, 2024
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 5, 2024
* master: refactor(core)!: Remove legacy `--file` flag for `execute` CLI command (#9054) fix(core): Ensure TTL safeguard for test webhooks applies only to multi-main setup (#9062) ci: Delete some duplicate code in cli tests (no-changelog) (#9049) refactor(core, editor): Remove legacy `nodesAccess` (no-changelog) (#9016) refactor(editor): Remove legacy audit logs view (no-changelog) (#9053) refactor(editor): Do not make rest api calls for disabled features (no-changelog) (#9046)
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review / Merge checklist