fix(editor): Show correct schema for output with falsy keys #9556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the output data contains objects that have properties with falsy values, the schema would incorrectly be hidden. This fixes the empty data check to show the schema in these cases.
mutdmour
approved these changes
May 31, 2024
2 flaky tests on run #5205 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9556 ↗︎
|
✅ All Cypress E2E specs passed |
n8n-assistant
bot
added
n8n team
tomi
deleted the
ado-1648-bug-schema-view-does-not-render-when-only-boolean-item
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the output data contains objects that have properties with falsy values, the schema would incorrectly be hidden. This fixes the empty data check to show the schema in these cases.
Before:
After:
Related tickets and issues
https://linear.app/n8n/issue/ADO-1648/bug-schema-view-does-not-render-when-only-boolean-item
Review / Merge checklist
(no-changelog)otherwise. (conventions)