fix(editor): Shrink #node-view-background to viewport size (no-changelog) #9616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
OlegIvaniv
approved these changes
Jun 4, 2024
|
✅ All Cypress E2E specs passed |
|
Got released with |
netroy
pushed a commit
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our
#node-view-backgroundis a10Kpxx10Kpxdiv that, by Chrome estimates, takes up about 400MB of memory. From what I've tested, this is completely unnecessary. This PR shrinks it down to viewport dimensions.Latest e2e run
Before (n8n workspace is a tiny rectange in the upper-left corner)
After
Related tickets and issues
Review / Merge checklist
(no-changelog)otherwise. (conventions)