fix(editor): Improve error messages around pinned data #9632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: refactor(core): Move curl endpoint to its own controller (no-changelog) (#9605) refactor(core): Restore test for execution pagination in Public API (no-changelog) (#9621) ci: Consistent tsconfig setup for backend packages and fix pnpm typecheck for composite packages (no-changelog) (#9604)
n8n-assistant
bot
added
n8n team
* master: ci: Fix typecheck for nodes-base (no-changelog) (#9630)
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #5318 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9632 ↗︎
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding new error message for invalid pinned data input:
Also, in consultation with @maxtkacz, improving the size limit error toasts:
Related tickets and issues
Fixes ADO-2028
Review / Merge checklist
(no-changelog)otherwise. (conventions)