fix(editor): Color node connections correctly in execution preview for nodes that have pinned data #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r nodes that have pinned data
mutdmour
approved these changes
Jun 7, 2024
n8n-assistant
bot
added
n8n team
1 flaky test on run #5363 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #9669 ↗︎
|
✅ All Cypress E2E specs passed |
tomi
deleted the
ado-2106-bug-pinned-item-shows-over-success-in-executions
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 7, 2024
* master: fix: Fix typo with submitted (no-changelog) (#9662) refactor(core): Revamp crash recovery mechanism for main mode (#9613) fix(editor): Improve dragndrop of input pills with spaces (#9656) fix(editor): Indent on tabs in expression fields (#9659) fix(editor): Color node connections correctly in execution preview for nodes that have pinned data (#9669) fix(core): Fix optional chaining in continue on fail check (#9667) feat(OpenAI Node): Allow to select Image analyze model & improve types (#9660)
RicardoE105
pushed a commit
that referenced
this pull request
Jun 9, 2024
…r nodes that have pinned data (#9669)
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 10, 2024
* master: feat(editor): Harmonize rendering of new-lines in RunData (#9614) refactor(editor): Fix remaining FE type check errors (no-changelog) (#9607) fix(editor): Remove template creds setup from workflow when copied (no-changelog) (#9673) refactor(editor): Stop expecting `null` execution status (no-changelog) (#9672) fix: Fix typo with submitted (no-changelog) (#9662) refactor(core): Revamp crash recovery mechanism for main mode (#9613) fix(editor): Improve dragndrop of input pills with spaces (#9656) fix(editor): Indent on tabs in expression fields (#9659) fix(editor): Color node connections correctly in execution preview for nodes that have pinned data (#9669) fix(core): Fix optional chaining in continue on fail check (#9667) feat(OpenAI Node): Allow to select Image analyze model & improve types (#9660)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix connection colors for pinned data nodes in execution preview
Also contains fixes to some misspellings and eslint issues
Before:
Production execution:
Manual Execution:
After:
Production execution:
Manual Execution:
Related tickets and issues
https://linear.app/n8n/issue/ADO-2106/bug-pinned-item-shows-over-success-in-executions
Review / Merge checklist
(no-changelog)otherwise. (conventions)