-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Execute Workflow Node): Continue on fail behaviour not correctly implemented #9890
Merged
ShireenMissi
merged 1 commit into
master
from
node-1447-fix-excute-workflow-continue-on-fail
Jul 1, 2024
Merged
fix(Execute Workflow Node): Continue on fail behaviour not correctly implemented #9890
ShireenMissi
merged 1 commit into
master
from
node-1447-fix-excute-workflow-continue-on-fail
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShireenMissi
changed the title
Fix(Execute Workflow Node): Continue on fail behaviour not correctly implemented
fix(Execute Workflow Node): Continue on fail behaviour not correctly implemented
Jun 28, 2024
n8n-assistant
bot
added
n8n team
Authored by the n8n team
node/improvement
New feature or request
labels
Jun 28, 2024
elsmr
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected 🎉
4 flaky tests on run #5733 ↗︎
Details:
10-undo-redo.cy.ts • 1 flaky test
5-ndv.cy.ts • 2 flaky tests
17-sharing.cy.ts • 1 flaky test
Review all test suite changes for PR #9890 ↗︎ |
✅ All Cypress E2E specs passed |
Merged
Got released with |
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using the Execute Workflow Node with multiple items and the following parameters/settings:
The expected behaviour is to run the sub-workflow for each item and return an error for the items that fail. However, there is a bug that causes the execution to stop once an item fails.
Fix:
This PR fixes the issue by adding the error to the output instead of throwing it and returning early. This allows the sub-workflow to continue running for the remaining items even if one item fails.
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1447/execute-workflow-continue-on-fail-not-correctly-implemented
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)