fix(core): Don't execute 'workflowExecuteBefore' hook on execution continuations #9905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
despairblue
added
the
release/backport
|
@valya I created a follow up issue to eventually write a regression test for this: https://linear.app/n8n/issue/PAY-1726/add-regression-test-for-workflow-execution-hooks |
valya
approved these changes
Jul 9, 2024
|
|
4 flaky tests on run #5848 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
10-undo-redo.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Undo/Redo > should undo/redo adding nodes |
Test Replay
Screenshots
Video
|
|
| Undo/Redo > should undo/redo adding connected nodes |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9905 ↗︎
despairblue
force-pushed
the
pay-1712-executions-counted-multiple-times-if-there-is-a-wait-node-on
branch
from
6f6d79b
to
cf7cae4
Compare
valya
approved these changes
Jul 9, 2024
|
✅ All Cypress E2E specs passed |
despairblue
deleted the
pay-1712-executions-counted-multiple-times-if-there-is-a-wait-node-on
branch
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
|
Got released with |
jeanpaul
pushed a commit
that referenced
this pull request
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since version 1.29.0 n8n executes the
workflow.preExecutehook whenever an execution transitions fromwaitingtorunning.workflow.preExecuteshould only be called once per execution.This was introduced by a combination of #8487 and #8601.
The former refactored the WorkflowRunner class. It passes the executionId to
runMainProcess, in the position where therestartExecutionIdis expected.This leads eventually to this code never executing:
n8n/packages/core/src/WorkflowExecute.ts
Lines 851 to 853 in 16b1a09
The latter PR attempted to fix this by calling
additionalData.hooks.executeHookFunctions('workflowExecuteBefore', []);directly inrunMainProcess.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/PAY-1712/executions-counted-multiple-times-if-there-is-a-wait-node-on-cloud
Review / Merge checklist
Docs updated or follow-up ticket created.release/backport(if the PR is an urgent fix that needs to be backported)