Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add docs sidebar to credential modal #9914

Merged
merged 9 commits into from
Jul 3, 2024
Merged

feat(editor): Add docs sidebar to credential modal #9914

merged 9 commits into from
Jul 3, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jul 2, 2024 •
edited
Loading

Summary

  • Add docs sidebar to credential modal
  • Experiment with 3 high traffic nodes (includes telemetry)
  • Refactor affected components to composition API
image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1389/tweak-creds-modal

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jul 2, 2024
@elsmr elsmr marked this pull request as ready for review July 2, 2024 14:51
@elsmr elsmr requested a review from cstuncsik July 3, 2024 08:57
@cypress Cypress
Copy link

cypress bot commented Jul 3, 2024

5 flaky tests on run #5756 ↗︎

0 398 0 0 Flakiness 5

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: 623d61926c
Status: Passed Duration: 05:25 💡
Started: Jul 3, 2024 10:55 AM Ended: Jul 3, 2024 11:01 AM
Flakiness  5-ndv.cy.ts • 3 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > should retrieve remote options when non-required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
Undo/Redo > should undo/redo adding nodes Test Replay Screenshots Video
Undo/Redo > should undo/redo adding connected nodes Test Replay Screenshots Video

Review all test suite changes for PR #9914 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit b2f8ea7 into master Jul 3, 2024
27 checks passed
@elsmr elsmr deleted the node-1389-tweak-creds-modal branch July 3, 2024 12:18
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Merged
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.49.0

adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jul 8, 2024
@elsmr @cstuncsik @adrian-martinez-onestic
feat(editor): Add docs sidebar to credential modal (n8n-io#9914)
540f036 
Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstuncsik cstuncsik cstuncsik approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elsmr @janober @cstuncsik