fix(Google Sheets Node): Append fails if cells have some default values added by data validation rules #9950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…google-sheets-exceeds-grid-limits-error-on-insert
michael-radency
added
n8n team
ShireenMissi
reviewed
Jul 5, 2024
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/append.operation.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/appendOrUpdate.operation.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/appendOrUpdate.operation.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/appendOrUpdate.operation.ts
Show resolved
Hide resolved
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/read.operation.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/update.operation.ts
Outdated
Show resolved
Hide resolved
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/update.operation.ts
Outdated
Show resolved
Hide resolved
…google-sheets-exceeds-grid-limits-error-on-insert
|
✅ All Cypress E2E specs passed |
1 flaky test on run #5810 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #9950 ↗︎
michael-radency
deleted the
node-1460-google-sheets-exceeds-grid-limits-error-on-insert
branch
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
|
Got released with |
jeanpaul
pushed a commit
that referenced
this pull request
Jul 11, 2024
…es added by data validation rules (#9950)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before updating, we insert an empty row to prevent the update request from failing. In the append operation, we were not sending the
lastDataRowparameter, so we check for the last data row after inserting an empty one. Usually, this works fine, but in cases where data validation rules add some default values, the row would not be treated as empty, causing us to attempt to update the next row, which does not exist.Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/NODE-1460/google-sheets-exceeds-grid-limits-error-on-insert