Clean up AircraftInstanceModel.isOnGround() method

n8rzz · Dec 19, 2016 · d8b7239 · d8b7239
1 parent 2e4cb1b
commit d8b7239
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/assets/scripts/aircraft/AircraftInstanceModel.js b/src/assets/scripts/aircraft/AircraftInstanceModel.js
@@ -1731,11 +1731,10 @@ export default class Aircraft {
      */
     isOnGround() {
         const error_allowance_ft = 5;
-        const apt = window.airportController.airport_get();
-        const rwy_elev = apt.getRunway(this.rwy_dep || this.rwy_arr).elevation;
-        const apt_elev = apt.position.elevation;
-        const nearRunwayAltitude = abs(this.altitude - rwy_elev) < error_allowance_ft;
-        const nearAirportAltitude = abs(this.altitude - apt_elev) < error_allowance_ft;
+        const airport = window.airportController.airport_get();
+        const runway = airport.getRunway(this.rwy_dep || this.rwy_arr);
+        const nearRunwayAltitude = abs(this.altitude - runway.elevation) < error_allowance_ft;
+        const nearAirportAltitude = abs(this.altitude - airport.position.elevation) < error_allowance_ft;
 
         return nearRunwayAltitude || nearAirportAltitude;
     }