Merge pull request #201 from n8rzz/bugfix/ATC-191

bugfix/ATC-191
n8rzz · Dec 18, 2016 · ec51eec · ec51eec
2 parents 31092c7 + c22d404
commit ec51eec
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,6 +36,7 @@
 
 
 
+
 ### Bugfixes
 - Moves `_comment` blocks in airport json file to be within object the are describing [#145](https://github.com/n8rzz/atc/issues/145)
 - Streamlines flight number generation and adds new method to add new callsigns to the existing list [#151](https://github.com/n8rzz/atc/issues/151)
@@ -74,3 +75,5 @@
 - Aircraft strips show arrival airport in uppercase [#108](https://github.com/n8rzz/atc/issues/108)
 - Updates `FixCollection.findFixByName()` to accept upper, mixed, or lower case fix name [#109](https://github.com/n8rzz/atc/issues/109)
 - Switching to a previously loaded airport does not clear previous airport fixes [#115](https://github.com/n8rzz/atc/issues/115)
+- Fixes `parseElevation()` so that it does not return NaN when it is given the string `'Infinity'` [#191] (https://github.com/n8rzz/atc/issues/191)
+    - Originally reported under [#756](https://github.com/zlsa/atc/issues/756)
diff --git a/src/assets/scripts/utilities/unitConverters.js b/src/assets/scripts/utilities/unitConverters.js
@@ -301,7 +301,9 @@ export const parseElevation = (elevation) => {
 
     // if its a number, we're done here.
     // This will catch whole numbers, floats, Infinity and -Infinity.
-    if (_isNumber(elevation)) {
+    // This checks if strings are given will skip the regex and exit early
+    // Also stops the function from returning NaN
+    if (_isNumber(elevation) || elevation === 'Infinity' || elevation === '-Infinity') {
         return parseFloat(elevation);
     }
 
@@ -320,3 +322,4 @@ export const parseElevation = (elevation) => {
 
     return parseFloat(parsedElevation);
 };
+
diff --git a/test/utilities/unitConverters.spec.js b/test/utilities/unitConverters.spec.js
@@ -129,4 +129,6 @@ ava('.parseElevation() should parse a string elevation into an elevation in feet
     t.true(parseElevation('-23m') === -75.45931758530183);
     t.true(parseElevation(Infinity) === Infinity);
     t.true(parseElevation(-Infinity) === -Infinity);
+    t.true(parseElevation('Infinity') === Infinity);
+    t.true(parseElevation('-Infinity') === -Infinity);
 });