Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CommandAircraft class to handle execution of aircraft commands #181

Closed
3 of 8 tasks
n8rzz opened this issue Dec 10, 2016 · 1 comment
Closed
3 of 8 tasks

Create CommandAircraft class to handle execution of aircraft commands #181

n8rzz opened this issue Dec 10, 2016 · 1 comment
Assignees
@n8rzz @Dabea
Labels
cloned to openscope moonshot refactor
Milestone
v3.3.0

Comments

@n8rzz
Copy link
Owner

n8rzz commented Dec 10, 2016 •
edited
Loading

  • Create class that accepts an AircraftInstanceModel and a CommandParser object as parameters
  • move run methods to this class
  • update refs to this with aircraft
  • address TODOs and FIXMEs
  • simplify where possible
  • abstract where possible
  • consolidate where possible (DRY)
  • add tests
@n8rzz n8rzz added the refactor label Dec 10, 2016
@n8rzz n8rzz changed the title Clean up / move aircraft command methods Create CommandAircraft class to handle execution of aircraft commands Dec 21, 2016
@n8rzz n8rzz mentioned this issue Dec 22, 2016
Merged
@n8rzz n8rzz self-assigned this Dec 22, 2016
@n8rzz n8rzz added this to the v3.3.0 milestone Dec 22, 2016
@n8rzz n8rzz mentioned this issue Dec 31, 2016
Merged
@n8rzz n8rzz mentioned this issue Jan 15, 2017
Closed
@erikquinn
Copy link
Collaborator

This issue was moved to openscope/openscope#92

@erikquinn erikquinn mentioned this issue Jan 17, 2017
Closed
8 tasks
@erikquinn erikquinn mentioned this issue Jan 19, 2017
Closed
@n8rzz n8rzz reopened this Jan 19, 2017
This was referenced Jan 22, 2017
Closed
Closed
@n8rzz n8rzz closed this as completed Jan 23, 2017
@n8rzz n8rzz removed the WIP label Jan 23, 2017
This was referenced Jan 23, 2017
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n8rzz n8rzz

@Dabea Dabea

Labels
cloned to openscope moonshot refactor
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
3 participants
@n8rzz @erikquinn @Dabea