feature/ATC-205 #245
feature/ATC-205 #245
Conversation
There was a problem hiding this comment.
This is a good start, but you're missing the flag in the airport list.
Now that the flag has been removed from the name, you will need to add it manually from within the UiController when the airportList is built for the modal. Let me know if you have any questions on that.
Be sure to visually test this when you're all finished up. You should be able to see the flag next to an airport name (that is wip: true) in the airport modal.
| @@ -1292,7 +1292,7 @@ export default class Aircraft { | |||
| const routeModel = new RouteModel(data[0]); | |||
| const airport = window.airportController.airport_get(); | |||
| const { name: starName } = airport.starCollection.findRouteByIcao(routeModel.procedure); | |||
|
|
|||
| let flag = airport.wip ? ' ⛿ ' : ''; | |||
There was a problem hiding this comment.
this can actually be removed. what we are trying to avoid is having the flag present within the readbacks, which is what we were getting before when the flag was present in the airport.name.
There was a problem hiding this comment.
Ahh I see. I misunderstood the goal but now I understand.
| log: `cleared to the ${airport.name} via the ${routeModel.procedure} arrival`, | ||
| say: `cleared to the ${airport.name} via the ${starName} arrival` | ||
| log: `cleared to the ${airport.name}${flag} via the ${routeModel.procedure} arrival`, | ||
| say: `cleared to the ${airport.name}${flag} via the ${starName} arrival` |
There was a problem hiding this comment.
${flag} can be removed here as well. not needed for the readbacks.
| @@ -14,7 +14,7 @@ | |||
| ### Minor | |||
| - Ensures proper removal of all `AircraftConflict` instances involving an aircraft that has been removed from the simulation [#133](https://github.com/n8rzz/atc/issues/133) | |||
| - Originally reported under [zlsa#734](https://github.com/zlsa/atc/issues/734) | |||
|
|
|||
| - Changes the names from haveing the flags in their name by adding WIP variable to the `AIRPORT_LOAD_LIST` in `airportLoadList` [#205](https://github.com/n8rzz/atc/issues/205) | |||
There was a problem hiding this comment.
having is spelled incorrectly and there are two spaces between name and by
|
The flags now display in the aircraft list |
|
however it is not pushed yet |
|
Added Space after the flag and now this one should be complete |
n8rzz
force-pushed
the
feature/ATC-205
branch
from
1d16c42 to
cd03c9b
Compare
completes #205
This adds
wipboolean to theAIRPORT_LOAD_LISTinairportLoadList.js.Then adds this to the readback variable that is displayed
This could be done with out the flag variable and done in the string inline like
log: 'cleared to the ${airport.name}${airport.wip ? ' ⛿ ' : ''} via the ${routeModel.procedure} arrival',however I think this is much cleaner.
'cleared to the ${airport.name}${flag} via the ${routeModel.procedure} arrival',