update findRandomExitPointForSIDIcao to handle invalid identifier

[n8rzz]

this all pretains to the StandardRouteCollection.findRandomExitPointForSIDIcao() method

example:

• airport: KSFO

• command: ${CALLSIGN} sid offshore9

• This should error in the ui and the console.

• there should be a specific check for a valid routeCollection, which throws if one doesn't exist

• The property name sid should be renamed to routeCollection.

• add additional test case(s)

note: will be invalidated by zlsa#752

[erikquinn]

• ...and please rename to findRandomExitPointforSID().

[n8rzz]

there's that pesky icao sneaking in, good call!

[n8rzz]

@erikquinn actually, will this method even be needed after we implement zlsa#752? Or is that issue more of a 'moonshot' goal? Do you have a timeframe in mind with that issue?

[erikquinn]

Hm. I guess not. :Smile:

[erikquinn]

And no that's no moonshot, it's kinda pathetic we don't do it already to be honest. Should be easy. Can be a next spring thing though.

[n8rzz]

like invalidated by #243 and #229

[erikquinn]

Covered by openscope/openscope#120. Closing.