Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Airlines, Aircraft and spawning from the Airport #243

Closed
n8rzz opened this issue Dec 23, 2016 · 2 comments
Closed

Separate Airlines, Aircraft and spawning from the Airport #243

n8rzz opened this issue Dec 23, 2016 · 2 comments

Comments

@n8rzz
Copy link
Owner

n8rzz commented Dec 23, 2016

see: http://codepen.io/n8rzz/pen/eBobXm?editors=0010 and http://codepen.io/erikquinn/pen/VmOKqp?editors=0012

@n8rzz n8rzz added the refactor label Dec 23, 2016
@n8rzz n8rzz added this to the v3.3.0 milestone Dec 23, 2016
@n8rzz n8rzz self-assigned this Dec 23, 2016
@n8rzz n8rzz added the WIP label Dec 25, 2016
@n8rzz
Copy link
Owner Author

n8rzz commented Dec 26, 2016

create the following:

  • single aircraft json file that is a combination of all individual aircraft definitions
  • single airline json file that is a combination of all individual airline definitions
  • AircraftCollection
  • tests AircraftCollection
  • AircraftDefinition
  • tests AircraftDefinition
  • AirlineCollection
  • tests AirlineCollection
  • simplified AirlineModel
  • tests simplified AirlineModel
  • navigationLibrary/FixCollection (non-static version of current FixCollection)
  • tests navigationLibrary/FixCollection (non-static version of current FixCollection)
  • navigationLibrary/FixModel
  • tests navigationLibrary/FixModel
  • trafficGenerator/SpawnPatternCollection
  • tests trafficGenerator/SpawnPatternCollection
  • trafficGenerator/SpawnPatternModel
  • tests trafficGenerator/SpawnPatternModel
  • trafficGenerator/SpawnScheduler
  • tests trafficGenerator/SpawnScheduler

TODO:

  • create addItems() and addItem() methods for SpawnPatternCollection
  • move initial delay calculation to SpawnPatternModel
  • handle updated spawnPattern object from airport json
  • create navigationLibrary (controller?) and add facades to access FixCollection and StandardRoute
  • move StandardRoute to navigationLibrary
  • Calculate position and heading for arriving aircraft (1 [x] 2[x])
  • integrate new AircraftCollection and SpawnScheduler into app
  • move position and heading calculation from AircraftCollection to SpawnPatternModel
  • handle arrival altitude ranges
  • determine destination for arrivals
  • initial departure speed NaN
  • improve delay calculations
  • provide way for SpawnScheduler to handle app pause
  • provide way for SpawnScheduler to handle loss of focus
  • provide way for SpawnScheduler to handle timewarp
  • provide way to reset applicable classes on airport change (AirlineCollection and AircraftCollection.definitionList should never change on airport change)
  • handle specific airline fleets
  • handle callsign logics within AirlineModel
  • add SpawnPatternModel to pool
  • move aircraftController and airlineController out of airportController and use the controllers to fire off the collection methods
  • move aircraft creation back to aircraftController
  • update airline_get to use airlineCollection
  • Handle other spawn types (cyclic, wave, surge)
  • handle initial spawn onLoad
  • pass navigationLibrary to canvasController and update .canvas_draw_sids()
  • make flightNumbers globally unique. UAL123 and AAL123 should not be possible
  • deprecate current aircraft.callsign properties
  • clear old schedules from timeouts queue on airport change (game_clear_timeout)
  • add readme for spawnPatterns
  • pass navigationLibrary to AircraftInstanceModel an AircraftFlightManagementSystem
  • move StandardRoute refs in airport to NavigationLibrary
  • move RouteModel to navigationLibrary
  • handle simple and complex RouteStrings, ex: YOSEM.YOSEM3.KSFO vs TULNI..AKOVI..EBBR (see: AircraftFlightManagementSystem.formatRoute)
  • handle departure preSpawns
  • remove deprecated properties, methods and files
    • AircraftModel
    • arrivals/
    • departures/
    • AirlineModelComplex
  • address b764 aircraft issue
  • fleet is undefined when instance model is instantiated
  • loading an airport without terrain fails
  • update/move view logic in AirportModel.set()
  • loading spinner and text under aircraft strips do not get removed when loading kbos
  • copy spawnMethod doc blocs with diagrams
  • add validateSpawnPatternData helper function that halts instantiation
  • add changelog entry
  • allow entrail property ( openscope#155 )
  • wave pattern not working ( openscope#156 )
  • update airport files with spawnPatterns (need help on below)
    • kjfk
    • kmsp
    • ksan
    • itba
    • omaa
    • vobl
    • wiii

NICE TO HAVE

these will become standalone issues if they cannot be finished

@erikquinn
Copy link
Collaborator

This issue was moved to openscope/openscope#135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants