Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract inline fix object out of ArrivalBase #56

Closed
n8rzz opened this issue Nov 1, 2016 · 2 comments
Closed

Abstract inline fix object out of ArrivalBase #56

n8rzz opened this issue Nov 1, 2016 · 2 comments
Assignees
@n8rzz
Labels
cloned to openscope refactor WIP
Milestone
v3.3.0

Comments

@n8rzz
Copy link
Owner

n8rzz commented Nov 1, 2016 •
edited
Loading

These lines are problematic:

for (let i = 0; i < options.fixes.length; i++) {
    this.fixes.push({ fix: options.fixes[i] });
}

this.fixes has a very specific use and having these inline objects is somewhat confusing. This needs improvement.
@n8rzz n8rzz added the refactor label Nov 1, 2016
@n8rzz n8rzz added this to the v3.0.x milestone Nov 1, 2016
@n8rzz n8rzz mentioned this issue Nov 1, 2016
Merged
@n8rzz n8rzz modified the milestones: v3.1.0, v3.2.0 Nov 15, 2016
@n8rzz n8rzz modified the milestones: v3.3.0, v3.2.0 Dec 19, 2016
@n8rzz n8rzz self-assigned this Jan 13, 2017
@n8rzz
Copy link
Owner Author

n8rzz commented Jan 13, 2017

#243

@n8rzz n8rzz added the WIP label Jan 13, 2017
@erikquinn erikquinn mentioned this issue Jan 17, 2017
Closed
@erikquinn
Copy link
Collaborator

This issue was moved to openscope/openscope#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n8rzz n8rzz

Labels
cloned to openscope refactor WIP
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
2 participants
@n8rzz @erikquinn