feature/ATC-77 #118
feature/ATC-77 #118
Conversation
|
@erikquinn I'm about half way through this one but I think there is enough here for you tho get an idea of where this is headed. This one might blow your hair back a little bit 😉 , so ask questions on the stuff that doesn't make sense. |
…xModel * Adds BaseCollection to FixCollection * Changes name of Position to PositionModel
* Updates tests to use implemented model, FixModel
|
@erikquinn this is as good as it's going to get before I finish #53. I added issues #120 and #121 for future work that can't be completed now, mostly because of #53. Take a look and give this a test drive, I want to make sure I didn't break anything. My tests show that I haven't, but I like to be sure. |
arguments for creating a fully formed modelSource instance, eliminating the need for the caller to also run .init() once a modelSource has been obtained.
…TC-77 Conflicts: - CHANGELOG.md
There was a problem hiding this comment.
I'm not sure if it's related to this specifically or not, but the only weirdness I noticed was that upon rerouting an aircraft (in this case from BSR.BSR2.KSFO to QUINN.BDEGA2.KSFO, they will climb of their own accord to very high altitude and not come down. They can be told to descend normally, but a strange altitude is being put in there. May or may not be related.
That aside, everything relating to fixes seems to be working properly, which, as I saw it in review, is the only place the reusability factory is put to work.
| * Remove a reusable from the collection and return it for use by the caller | ||
| * | ||
| * @for ModelSourcePool | ||
| * @method releasModelFromPool |
There was a problem hiding this comment.
done
I'm so glad I have you look over these PRs for me.
| * @private | ||
| */ | ||
| _removeItem(model) { | ||
| this._items = _without(this._items, model); |
There was a problem hiding this comment.
👍 that's a neat lodash function... it will come in handy 😄
There was a problem hiding this comment.
And it doesn't mutate _items it returns an entirely new array.
|
@erikquinn added #155 for the bug you reported. It may be something, it may not, but at least we have visibility. |
completes #77
Adds initial code for ModelSourceFactory and ModelSourcePool