feature/ATC-175 #226
Merged
feature/ATC-175 #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TC-175 Conflicts: - CHANGELOG.md
n8rzz
approved these changes
Dec 19, 2016
| @@ -467,11 +467,23 @@ export default class StandardRouteModel extends BaseModel { | |||
|
|
|||
| if (this._entryCollection) { | |||
| const entrySegment = this._entryCollection.findSegmentByName(entry); | |||
|
|
|||
| if (entrySegment === undefined) { | |||
There was a problem hiding this comment.
The StandardRoute files are heavily tested so I would like to see some tests for this new stuff. In the interest of time, I'll whip some up here.
| @@ -467,11 +467,23 @@ export default class StandardRouteModel extends BaseModel { | |||
|
|
|||
| if (this._entryCollection) { | |||
| const entrySegment = this._entryCollection.findSegmentByName(entry); | |||
|
|
|||
| if (entrySegment === undefined) { | |||
There was a problem hiding this comment.
this should be typeof entrySegment === 'undefined'. javascript is a little particular about comparisons with undefined and using typeof with strict equals (===) is the best way to check for undefined. I"ll make that change while I'm writing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #175.
I... think I fixed it? Should probably play around with it to see if other errors come up, but the one described in the issue is resolved.