Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed platforms list in library.json #742

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Fixed platforms list in library.json #742

merged 1 commit into from
Mar 4, 2021

Conversation

dagix5
Copy link

@dagix5 dagix5 commented Mar 4, 2021

Fix for #741

Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this error and forgot to fix it. Thank you. Does PIO not allow installing current version because of this?

@dagix5
Copy link
Author

dagix5 commented Mar 4, 2021

I guess but I'm not sure. I added the library with the git tag and saw the warning in the compilation log.

@2bndy5
Copy link
Member

2bndy5 commented Mar 4, 2021

I only asked because we could change the commit that was tagged for v1.3.12, but
v1.3.12 doesn't even show up in versions list under PIO Home->Registry->RF24. So I think we are ok to release the fix under v1.3.13, and leave the tag for v1.3.12 as is.

@2bndy5 2bndy5 merged commit d1dffc5 into nRF24:master Mar 4, 2021
@dagix5
Copy link
Author

dagix5 commented Mar 4, 2021

Yep, I noticed it. Actually, it shows the version in the changelog tab even though the version is not in the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants