Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc tweaks and reusable CI #887

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Doc tweaks and reusable CI #887

merged 5 commits into from
Jan 9, 2023

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Dec 31, 2022

I wanted to add a "table of contents" list to all Doxygen's "Main/Related Pages", but then I had to update the CI and doxygen CSS...

Doxygen now supports light and dark themes finally. 👀 I've set the new feature to be able to toggle light/dark theme (button is located next to search box). It should default to whatever theme the OS is using. This feature requires Doxygen v1.9.5+ (CI is now using v1.9.6).

Reduced old copy of customized Doxygen CSS; it was no longer compatible with latest version of Doxygen and the feature discussed above. Besides, it seemed like a simple dump of the default CSS from an older version Doxygen.

I also updated the sphinx CSS in accordance with the sphinx-immaterial theme v0.11.0 release.

Slight docs refactor

Both Doxyfile and the doxygen-custom.css files now exist in docs/ folder. This is done to try and reduce the clutter in root folder. I added some build instructions to the docs/README.md. Basically, this change means you have to run doxygen from the docs folder

cd docs && doxygen

instead of running doxygen from the root folder.

@2bndy5 2bndy5 force-pushed the doc-tweaks branch 8 times, most recently from 72e8fe0 to 97358ca Compare January 1, 2023 10:02
2bndy5 added 3 commits January 1, 2023 02:30
- show Table of Contents in Doxygen's Main/Related Pages
- update sphinx customized CSS and conf.py
- remove note about pyRF24 API
use latest doxygen release

update set-output cmd in docs CI

update action versions in docs CI
@2bndy5
Copy link
Member Author

2bndy5 commented Jan 1, 2023

If the "slight refactor" is acceptable, then I'll go ahead and make the same changes to other RF24* libs' docs.

@TMRh20
Copy link
Member

TMRh20 commented Jan 2, 2023

I had to make some changes to the paths in the Doxyfile to get it working as per my commits, but not sure why the docs build is failing now...

@2bndy5
Copy link
Member Author

2bndy5 commented Jan 2, 2023

Because the paths were written so doxygen is executed from the root folder. I think your changes should work only if doxygen is executed from the docs folder.

@TMRh20
Copy link
Member

TMRh20 commented Jan 2, 2023 via email

@2bndy5
Copy link
Member Author

2bndy5 commented Jan 2, 2023

I'm on it. I'm going with the assumption that you want to build docs from the docs folder (not the root folder anymore).

@2bndy5
Copy link
Member Author

2bndy5 commented Jan 2, 2023

ok, I fixed it so doxygen should be executed from the docs folder.

@TMRh20
Copy link
Member

TMRh20 commented Jan 2, 2023

Yeah, I was executing it from the docs folder thinking it should be. I guess we can go with that now lol.
I'm also good with applying this to all of RF24.

@2bndy5
Copy link
Member Author

2bndy5 commented Jan 2, 2023

If I ever incorporate doxygen into cmake (unlikely), then it will probably change again anyway. Honestly, I'd like to support clang better in cmake rather than doxygen.

@2bndy5
Copy link
Member Author

2bndy5 commented Jan 4, 2023

BTW, the sphinx-immaterial theme can make use of github discussions as user feedback (embedded directly in the doc pages via giscus). See my demo/test (scroll to bottom of page). Just thought I'd throw that out there.

@2bndy5
Copy link
Member Author

2bndy5 commented Jan 6, 2023

I'm going to switch to using reusable workflows in most of the nRF24 org repos' CI. This will make updating the CI across all repos much easier (no more separate PR per repo). So far, the tests on this branch are successfully using workflows that I created in the nRF24/.github repo (on reusable-workflow branch).

In other words the doc-update PRs are not finalized yet...

@2bndy5 2bndy5 marked this pull request as draft January 6, 2023 04:47
@2bndy5 2bndy5 force-pushed the doc-tweaks branch 2 times, most recently from 1fcf5dc to 3a20a9a Compare January 7, 2023 11:47
2bndy5 added 2 commits January 8, 2023 13:02
- revert some Doxygen CSS changes
- update RTD build

Update paths

Update Doxyfile

One more modification

update all CI

also amend readme instructions

fix RTD build and some CI changes

fix doxyfile config value

keep doxygen output relative to root

self review changes


restore dynamic version number in Doxyfile
@2bndy5 2bndy5 marked this pull request as ready for review January 8, 2023 21:39
@2bndy5
Copy link
Member Author

2bndy5 commented Jan 8, 2023

That felt rare. I don't often trigger hundreds of CI runs (across 6 org repos) simultaneously; even rarer that nothing went wrong. 🎉

@2bndy5
Copy link
Member Author

2bndy5 commented Jan 9, 2023

Yeah I'm ready to move on from these Doc Updates PRs.

The only thing left to look out for is release CI behavior, but I'm confidence that everything should go well. Rebasing the promiscuouos-scanners branch should be interesting because there's a new curses example there (with CMake and CI changes).

@2bndy5 2bndy5 changed the title Doc tweaks Doc tweaks and reusable CI Jan 9, 2023
@2bndy5 2bndy5 merged commit e490a5a into master Jan 9, 2023
@2bndy5 2bndy5 deleted the doc-tweaks branch January 9, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants