-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPIO changes (RPi5 support) #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this on any of my own hardware yet. This review is just my first glance reactions.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Gotta say as someone who struggles with formatting and syntax, this Linter Bot is great. Hehehe. |
I figured you'd enjoy it 😉. I was worried the bot might be perceived as spamming the conversation... I opened cpp-linter/cpp-linter#77 to prevent the duplicated LGTM reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cpp-linter Review
No concerns from clang-format.
Great job! 🎉
Have any feedback or feature suggestions? Share it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked on my RPi3 & RPi4 (both using RPi OS bookworm with latest updates).
Maybe in the future we can use this character device API to implement IRQ using the Linux kernel... For now this solves #932
I like the "maybe in the future" part. The rest sounds like a lot of work. 😜 Really though, might be something to look into. |
This guide does mention how IRQ could be done using some The main obstacle (for me) is using a separate processor thread to poll the GPIO for IRQ edge detection. |
Hmm, maybe u should open an issue for this enhancement. I played around with threads before, the IRQ stuff has gone through a bunch of changes. It can't be that hard. hehe. |
I think this is pretty much ready to go now, I've been testing it out on all my RPis with various code/RF24 layers and it seems to work fine.
Re: #932