-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #28 #29
Fix for #28 #29
Conversation
With this fix, we should now be able to add the boards in question to the PlatformIO CI workflow (which should also validate this PR's intentions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validated via PIO CI
@TMRh20 If you're thinking of a release crusade, there's a doc change that I'd like to push in RF24 (about using cmake) beforehand. |
Soon. I’m troubleshooting an issue with the interactive server example where it responds to ping but not http requests after like 17 days or more. I have a guess as to a fix but not much more. So I’m trying to fix it before the next release.
… On Jun 11, 2022, at 2:31 PM, Brendan ***@***.***> wrote:
@TMRh20 If you're thinking of a release crusade, there's a doc change that I'd like to push in RF24 (about using cmake) beforehand.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Could it have something to do with using size_t? Here's a snippet from cppreference.com
|
I dunno, I have a hunch it has to do with the UIP_TIMER_DIVISOR being set too high, but that's just a guess. I'll have to see about this size_t thing as well. |
Well the timer divisor thing did nothing. I'm now trying it with the while() loop in the sketch changed to an if. Can't see where else it would loop like that... I really want to get this bug fixed before the next release, so I have three nodes running the modified sketch, and if they all stay online for 20+ days then its a win. If not, we can do a release anyway... |
Wouldn't hurt to have a thread for this problem to track it properly. |
Rename timer.h and timer.c
Closes #28