Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #28 #29

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Fix for #28 #29

merged 2 commits into from
Jun 15, 2022

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Jun 11, 2022

Rename timer.h and timer.c

Closes #28

Rename timer.h and timer.c
@TMRh20 TMRh20 requested a review from 2bndy5 June 11, 2022 13:15
@2bndy5
Copy link
Member

2bndy5 commented Jun 11, 2022

With this fix, we should now be able to add the boards in question to the PlatformIO CI workflow (which should also validate this PR's intentions).

Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validated via PIO CI

@2bndy5
Copy link
Member

2bndy5 commented Jun 11, 2022

@TMRh20 If you're thinking of a release crusade, there's a doc change that I'd like to push in RF24 (about using cmake) beforehand.

@TMRh20
Copy link
Member Author

TMRh20 commented Jun 11, 2022 via email

@2bndy5
Copy link
Member

2bndy5 commented Jun 12, 2022

Soon. I’m troubleshooting an issue with the interactive server example where it responds to ping but not http requests after like 17 days or more. I have a guess as to a fix but not much more. So I’m trying to fix it before the next release.

Could it have something to do with using size_t? Here's a snippet from cppreference.com

std::size_t is commonly used for array indexing and loop counting. Programs that use other types, such as unsigned int, for array indexing may fail on, e.g. 64-bit systems when the index exceeds UINT_MAX or if it relies on 32-bit modular arithmetic.

@TMRh20
Copy link
Member Author

TMRh20 commented Jun 12, 2022

I dunno, I have a hunch it has to do with the UIP_TIMER_DIVISOR being set too high, but that's just a guess. I'll have to see about this size_t thing as well.

@TMRh20
Copy link
Member Author

TMRh20 commented Jun 15, 2022

Well the timer divisor thing did nothing. I'm now trying it with the while() loop in the sketch changed to an if. Can't see where else it would loop like that... I really want to get this bug fixed before the next release, so I have three nodes running the modified sketch, and if they all stay online for 20+ days then its a win. If not, we can do a release anyway...

@TMRh20 TMRh20 merged commit 8358b42 into master Jun 15, 2022
@2bndy5
Copy link
Member

2bndy5 commented Jun 15, 2022

Wouldn't hurt to have a thread for this problem to track it properly.

@TMRh20 TMRh20 deleted the Fix#28 branch June 19, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting header inclusion timer
2 participants