Make most #defines in RF24Network_config.h conditional ... #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set from project code or compiler command line.
2bndy5
approved these changes
Apr 12, 2021
|
These changes don't affect doxygen output 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so they can be set from project code or compiler command line.
As discussed at nRF24/RF24#727 (comment)
I'm not sure how to handle things that are either defined or not, i.e. don't have a value (such as
#define RF24NetworkMulticast). I'd say that the preferred way would be to always assign a value (TRUEorFALSE) to them but always have them defined?