-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround for printf issue #207
Conversation
Workaround for printf issue identified in issue nRF24/RF24Gateway#25
Funny stuff going on with the printfs, maybe this should all be changed to use |
That would only work on Arduino though, right? It is wierd that the solution is to handle |
Yeah, not really a good solution. I'll have to pick this up tomorrow or sometime soon. I haven't been using RF24Gateway with the interrupts enabled because it needs root. |
I asked about the ISR because I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Arduino CI wasn't triggered because there were no changes to the Arduino examples. But, I'm guessing you tested this on the Arduino Nano already. All other CI is happy now, thanks!
Before this gets released, we have to revert the changes in 7a7a854 and put them in a separate branch Similarly with changes in nRF24/RF24Mesh@b774f03, they should go into a separate branch and removed from master. Now that nrf_to_nrf is available in the Arduino Lib manager, we could also add that lib as a dependency for these network layers. |
After some thought, I think we have a bigger issue here with printf not working. Printing the millis() separately kind of works, but I am guessing its just overflowing data somewhere else because I am getting strange behaviour with debug enabled now. |
- Removed all the millis() printfs - Removed header.toString calls
Yeah, I would like to get this all figured out soon, we are past due for a release of all RF24 libs. Changes reverted, new branches created |
Delete commented millis() debug statements
Workaround for printf issue identified in issue nRF24/RF24Gateway#25