Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template layer for radio HW abstraction #210

Merged
merged 11 commits into from
Jun 8, 2023
Merged

Template layer for radio HW abstraction #210

merged 11 commits into from
Jun 8, 2023

Conversation

2bndy5
Copy link
Member

@2bndy5 2bndy5 commented Jun 7, 2023

solves #204

This layer was unique in that I had to re-write the python wrapper to allow for using the renamed template class. Everything else is typical template implementation.

  • RF24Network is now a backward compatible type definition that aliases the RF24 specialization of the ESBNetwork class.
  • RF52Network is a type definition that aliases the nrf_to_nrf specialization of the ESBNetwork class.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Memory usage change @ ecba37c

Board flash % RAM for global variables %
arduino:avr:nano 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrzero 🔺 +40 - +44 +0.02 - +0.02 🔺 +16 - +16 +0.05 - +0.05
Click for full report table
Board examples/helloworld_rx
flash
% examples/helloworld_rx
RAM for global variables
% examples/helloworld_rx_advanced
flash
% examples/helloworld_rx_advanced
RAM for global variables
% examples/helloworld_tx_advanced
flash
% examples/helloworld_tx_advanced
RAM for global variables
% examples/helloworld_tx
flash
% examples/helloworld_tx
RAM for global variables
% examples/Network_Priority_RX
flash
% examples/Network_Priority_RX
RAM for global variables
% examples/Network_Priority_TX
flash
% examples/Network_Priority_TX
RAM for global variables
%
arduino:avr:nano 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrzero 44 0.02 16 0.05 44 0.02 16 0.05 40 0.02 16 0.05 40 0.02 16 0.05 44 0.02 16 0.05 40 0.02 16 0.05
Click for full report CSV
Board,examples/helloworld_rx<br>flash,%,examples/helloworld_rx<br>RAM for global variables,%,examples/helloworld_rx_advanced<br>flash,%,examples/helloworld_rx_advanced<br>RAM for global variables,%,examples/helloworld_tx_advanced<br>flash,%,examples/helloworld_tx_advanced<br>RAM for global variables,%,examples/helloworld_tx<br>flash,%,examples/helloworld_tx<br>RAM for global variables,%,examples/Network_Priority_RX<br>flash,%,examples/Network_Priority_RX<br>RAM for global variables,%,examples/Network_Priority_TX<br>flash,%,examples/Network_Priority_TX<br>RAM for global variables,%
arduino:avr:nano,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrzero,44,0.02,16,0.05,44,0.02,16,0.05,40,0.02,16,0.05,40,0.02,16,0.05,44,0.02,16,0.05,40,0.02,16,0.05

@2bndy5
Copy link
Member Author

2bndy5 commented Jun 7, 2023

That size report is interesting. Good to know these changes don't negatively affect the nano.

@2bndy5 2bndy5 force-pushed the template-attempt2 branch from ecba37c to 1067f90 Compare June 7, 2023 01:05
@2bndy5
Copy link
Member Author

2bndy5 commented Jun 8, 2023

tested on PicoSDK and Linux python wrapper ✔️

@2bndy5 2bndy5 merged commit a334fa6 into master Jun 8, 2023
@2bndy5 2bndy5 deleted the template-attempt2 branch June 21, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants