New subfleet not being attached to an airline on import #479 (#505)

* Fix subfleet not being attached to an airline on creation in import #479 * Call airline name with optional() around subfleet * Minor cleanup
nabeelio · Jan 16, 2020 · d03a77b · d03a77b
1 parent 6fcbd60
commit d03a77b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/app/Services/ImportExport/AircraftImporter.php b/app/Services/ImportExport/AircraftImporter.php
@@ -4,6 +4,7 @@
 
 use App\Contracts\ImportExport;
 use App\Models\Aircraft;
+use App\Models\Airline;
 use App\Models\Enums\AircraftState;
 use App\Models\Enums\AircraftStatus;
 use App\Models\Subfleet;
@@ -32,19 +33,21 @@ class AircraftImporter extends ImportExport
     ];
 
     /**
-     * Find the subfleet specified, or just create it on the fly
+     * Find the subfleet specified, or just create it on the fly and attach it to the
+     * first airline that's been found
      *
      * @param $type
      *
      * @return Subfleet|\Illuminate\Database\Eloquent\Model|null|object|static
      */
     protected function getSubfleet($type)
     {
-        $subfleet = Subfleet::firstOrCreate([
+        return Subfleet::firstOrCreate([
             'type' => $type,
-        ], ['name' => $type]);
-
-        return $subfleet;
+        ], [
+            'name'       => $type,
+            'airline_id' => Airline::where('active', true)->first()->id,
+        ]);
     }
 
     /**

diff --git a/resources/views/admin/subfleets/table.blade.php b/resources/views/admin/subfleets/table.blade.php
@@ -15,7 +15,7 @@
                 {{ $subfleet->name }}
                 </a>
             </td>
-            <td>{{ $subfleet->airline->name }}</td>
+            <td>{{ optional($subfleet->airline)->name }}</td>
             <td>{{ $subfleet->type }}</td>
             <td>{{ $subfleet->aircraft->count() }}</td>
             <td class="text-right">

diff --git a/tests/ImporterTest.php b/tests/ImporterTest.php
@@ -564,7 +564,8 @@ public function testFlightImporterEmptyCustomFields(): void
      */
     public function testAircraftImporter(): void
     {
-        $subfleet = factory(App\Models\Subfleet::class)->create(['type' => 'A32X']);
+        factory(App\Models\Airline::class)->create();
+        // $subfleet = factory(App\Models\Subfleet::class)->create(['type' => 'A32X']);
 
         $file_path = base_path('tests/data/aircraft.csv');
         $status = $this->importSvc->importAircraft($file_path);
@@ -579,8 +580,9 @@ public function testAircraftImporter(): void
 
         $this->assertNotNull($aircraft);
         $this->assertNotNull($aircraft->hex_code);
-        $this->assertEquals($subfleet->id, $aircraft->id);
-        $this->assertEquals($subfleet->type, $aircraft->subfleet->type);
+        $this->assertNotNull($aircraft->subfleet);
+        $this->assertNotNull($aircraft->subfleet->airline);
+        $this->assertEquals('A32X', $aircraft->subfleet->type);
         $this->assertEquals('A320-211', $aircraft->name);
         $this->assertEquals('N309US', $aircraft->registration);
         $this->assertEquals(null, $aircraft->zfw);