Prefile with airport ICAO not in database causes error when selecting PIREP

[xterminator24]

Describe the bug
Our VA allows pilots to fly to destinations that may not yet be in the airports database. Completing a PREFILE through the /pipreps/prefile endpoint allows for this scenario as there is no checking that the departure and arrival airports exist in the database. The prefile shows up in the user's PIREPS list as "In Progress" as this shows https://imgur.com/Y10MUe9

However, if you click on the flight number in the PIREP list you get an Invalid argument exception error. "The error says Position elements must be integers or floats". I believe this is most likely due to the airport not having position coordinates in the airports table.

Version
7.0.0-beta4

To Reproduce
Steps to reproduce the behavior:

1. Prefile through the API using the /pireps/prefile endpoint using an airport ICAO that doesn't exist in the airports table
2. Visit the users PIREPS page by clicking on the option on the menu bar
3. Click on the flight number in the PIREPS list
4. https://imgur.com/ZZ4DeqE

Expected behavior
I would like to see the PIREP form still pull up but maybe without the line drawing on the map. The header that contains the airport info would also need to just display the ICAO for the airport that isn't in the database. I actually like the fact that you can fly to airports not yet in the database if you want as that increases possibilities for VA's. If VA's want to limit to only airports in the database, they could verify it's existence before allowing the prefile.

Screenshots
https://imgur.com/Y10MUe9
https://imgur.com/ZZ4DeqE

[nabeelio]

Thanks, it's actually supposed to add a placeholder airport with a 0,0 coordinate. I think I need to add a setting in order for it to try to do that (either as a lookup or just a default value). I probably missed that in a code path here.

[nabeelio]

Actually I noticed you're using the beta, can you try the latest dev? I might have changed that behavior there already.

[nabeelio]

There is this setting, I think I need to expand it out to the prefile, etc

[nabeelio]

Ok, I think I need to add a new setting, "Allow unadded airports", an dthen look those up

[xterminator24]

I tested the prefile with the latest DEV build (7.0.0-dev+200812.3ac03d) and encountered the same problem when the flight contains an airport not in the database. If you could automatically add an airport on the fly during a prefile, that would be amazing!

[nabeelio]

How do you handle flight numbers and stuff? Just a generic flight number?

[nabeelio]

Hey, can you try the above PR/branch to see if this is what you're looking for? There is a new setting that is off by default for "Allow unadded airports"