Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化helm rpc通信端口,更新helm文档 #175

Merged
merged 4 commits into from
Nov 16, 2020

Conversation

yl-yue
Copy link
Contributor

@yl-yue yl-yue commented Nov 7, 2020

#172 关联此问题,完成以下helm优化:

  1. 区分http与rpc通信端口
  2. 更新helm文档说明

备在:
问题当中提到的helm版本问题,可以采用git创建分支与标签并结合Chart.yamlversion区分实现

Copy link
Collaborator

@paderlol paderlol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个rpc端口不需要对外开放,是pod节点之间通讯的,所以不需要nodeport,我之前说小问题就是因为我当时写错了

@yl-yue
Copy link
Contributor Author

yl-yue commented Nov 9, 2020

spec:
  type: {{ .Values.service.type }}
  ports:
    - port: {{ .Values.service.port }}
      targetPort: http
      protocol: TCP
      name: http
      {{- if eq .Values.service.type "NodePort" }}
      nodePort: {{ .Values.service.nodePort }}
      {{- end }}
    - port: 7848
      name: rpc
      targetPort: 7848

已移除rpc nodeport与文档描述,建议多对helm Chart.yaml 进行版本修改,这样可以选择不同版本的模板进行构建nacos集群

@paderlol paderlol merged commit 569b8f7 into nacos-group:master Nov 16, 2020
@paderlol
Copy link
Collaborator

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants