Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #537] Fix naming http client authentication. #538

Conversation

pixystone
Copy link
Contributor

FIX #537

@codecov-commenter
Copy link

Codecov Report

Base: 29.99% // Head: 31.14% // Increases project coverage by +1.14% 🎉

Coverage data is based on head (2d1a525) compared to base (a13f6f2).
Patch coverage: 69.56% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage   29.99%   31.14%   +1.14%     
==========================================
  Files          40       40              
  Lines        2967     2983      +16     
==========================================
+ Hits          890      929      +39     
+ Misses       2013     1988      -25     
- Partials       64       66       +2     
Impacted Files Coverage Δ
...nts/naming_client/naming_http/naming_http_proxy.go 0.00% <0.00%> (ø)
common/nacos_server/nacos_server.go 16.98% <88.23%> (+15.37%) ⬆️
clients/naming_client/naming_http/beat_reactor.go 70.00% <100.00%> (-5.00%) ⬇️
.../naming_client/naming_cache/service_info_holder.go 27.36% <0.00%> (+2.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binbin0325 binbin0325 merged commit 61c06ae into nacos-group:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.x 持久化实例Naming Auth签名走的httpProxy,需要cherry-pick一下1.x的Naming Auth实现
3 participants