Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine #552

Merged
merged 1 commit into from
Dec 26, 2022
Merged

refine #552

merged 1 commit into from
Dec 26, 2022

Conversation

binbin0325
Copy link
Member

fixes:#545

@codecov-commenter
Copy link

Codecov Report

Base: 31.33% // Head: 31.15% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (d1d6551) compared to base (df401c2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   31.33%   31.15%   -0.19%     
==========================================
  Files          40       40              
  Lines        2981     2979       -2     
==========================================
- Hits          934      928       -6     
- Misses       1982     1985       +3     
- Partials       65       66       +1     
Impacted Files Coverage Δ
clients/naming_client/naming_client.go 39.08% <ø> (-0.70%) ⬇️
common/remote/rpc/grpc_client.go 0.00% <ø> (ø)
common/remote/rpc/grpc_connection.go 0.00% <ø> (ø)
common/remote/rpc/rpc_client.go 0.00% <0.00%> (ø)
common/remote/rpc/server_request_handler.go 0.00% <ø> (ø)
clients/naming_client/naming_http/beat_reactor.go 70.00% <0.00%> (-5.00%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binbin0325 binbin0325 merged commit c819fd3 into nacos-group:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants