Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log it when response is fail and no error #652

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

sodaRyCN
Copy link
Contributor

@sodaRyCN sodaRyCN commented Aug 30, 2023

653

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (b51d87d) 30.05% compared to head (16a3d24) 30.03%.

❗ Current head 16a3d24 differs from pull request most recent head 3c458e6. Consider uploading reports for the commit 3c458e6 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   30.05%   30.03%   -0.02%     
==========================================
  Files          40       40              
  Lines        3068     3070       +2     
==========================================
  Hits          922      922              
- Misses       2079     2081       +2     
  Partials       67       67              
Files Changed Coverage Δ
common/remote/rpc/rpc_client.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@binbin0325 binbin0325 merged commit 9653dde into nacos-group:master Sep 1, 2023
yesAnd92 pushed a commit to yesAnd92/nacos-sdk-go that referenced this pull request Nov 3, 2023
* log when response is fail and no error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants