feat: flexible order time selection ui changes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameerul-deriv
approved these changes
Aug 24, 2023
...2p/src/components/modal-manager/modals/order-time-tooltip-modal/order-time-tooltip-modal.tsx
Outdated
Show resolved
Hide resolved
...2p/src/components/modal-manager/modals/order-time-tooltip-modal/order-time-tooltip-modal.tsx
Outdated
Show resolved
Hide resolved
|
⏳ Generating Lighthouse report... |
farhan-nurzi-deriv
approved these changes
Aug 24, 2023
| export const order_list = { | ||
| ACTIVE: 'active', | ||
| INACTIVE: 'inactive', | ||
| }; | ||
|
|
||
| export const order_time_info_message = localize('Orders will expire if they aren’t completed within this time.'); |
niloofar-deriv
approved these changes
Aug 28, 2023
farrah-deriv
approved these changes
Aug 28, 2023
nada-deriv
merged commit 4d91c47
into
nada/P2PS-637/flexible-order-time
2 checks passed
nada-deriv
pushed a commit
that referenced
this pull request
Sep 7, 2023
* refactor: ts migration of chart loader * refactor: ts migration of screen large form and started purchase * refactor: add types in store and refcator contract * refactor: ts migaration of purchase field * refactor: ts migration of cancel deal info * refactor: ts migration of the purchase btn * refactor: cancel deal info * refactor: remove simular types * refactor: create file for types * chore: cover return value with react fragment * refactor: apply suggestions * refactor: update imports * refactor: type returned value * refactor: left an explanation of expecting ts error * Akmal / feat: migrate EmptyPortfolioMessage, ErrorComponent and Page404 in Trader package (#5) * feat: migrate Page404 to Typescript * feat: migrate EmptyPortfolioMessage to Typescript * feat: migrate ErrorComponent to Typescript * fix: dialog prop * fix: dialog type * chore: remove React.FC * maryia/WEBREL-321/feat: migrate Actions files to TS (#4) * feat: migrate /contract-type.js to ts & remove barrier.js * feat: migrate duration to ts + remove unused currency.js * feat: migrate actions/purchase to ts * feat: migrate actions/symbol to ts * feat: migrate start-date.js to ts * feat: migrate actions/test.js to ts * chore: improve types in start-date and duration * fix: address review comments * revert: unnecessary line deletion * fix: address reviews * refactor: remove some code smells * refactor: remove code smells * refactor: update types in stores * Akmal / feat: migrate utils in Trader package (deriv-com#9) * feat: migrate MarketUnderlying to Typescript * feat: migrate errors to Typescript * feat: migrate error spec to Typescript * feat: migrate index to Typescript * feat: migrate validator to Typescript * feat: trigger vercel * chore: sort options alphabetically * fix: TValidationResult type * chore: prettier formatting * refactor: reduce code smells * chore: validator type improvements (deriv-com#12) * Kate / DTRA-249 / Code refactoring and removing duplicated files (deriv-com#13) * refactor: remove duplicated file * refactor: test improvements * fix: removed forgotten import * chore: empty commit to retrigger checks * refactor: apply suggestion * maryia/DTRA-260/TS migration of /Constants files & SmartChart/Helpers files in Trader (#6) * feat: validation-rules and ui.js to ts * chore: squash merge maryia/WEBREL-321/actions-to-TS changes * chore: added types to validation-rules.ts * chore: remove unused ui.js, migrate used ui.js and index.js to ts * chore: remove unused ui.js * chore: remove unused markers.js, and migrate barriers.js to ts * chore: added types to barriers.js and its test * test: add missing test for removeBarrier to barriers * Revert "chore: squash merge maryia/WEBREL-321/actions-to-TS changes" * feat: migrated chart-barrier-store.js to ts * feat: remove unused ChartMarkerStore * build: trigger build * fix: address review comments * henry/webrel-319/ts-migration-modules-trading-helpers-folder (deriv-com#11) * fix: merge conflicts * fix: resolve comments * fix: remove comment * fix: add loadash types dependency * refactor: move error type to common props file * fix: circle CI * fix: resolve comment * fix: bug * fix: convert returntype to use ttradestore * empty commit * fix: type change * fix: resolve comments * fix: comments * maryia/861n17c54/fix: sonarcloud warnings (deriv-com#14) * fix: sonarcloud warnings * fix: types * fix: resolve conflicts * refactor: apply suggestions * refactor: add last suggestion * refactor: tests * refactor: update function * refactor: add ts migration of exist tests * fix: tests * fix: test case --------- Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com>
nada-deriv
pushed a commit
that referenced
this pull request
Sep 20, 2023
…hint chore: refactored temporarily barred hint component
nada-deriv
pushed a commit
that referenced
this pull request
Sep 27, 2023
* fix: initial commit * fix: initial setup for useReportsStore * chore: remove connect from account-statistics (#2) * chore: remove connect from filter-component (#3) * fix: refactor useReportsStores * chore: remove connect from Indicative-cell (#4) * fix: reduce typescript errors * fix: sonarcloud * fix: resolve typescript errors * chore: remove connect from composite-calendar * fix: type fix * fix: remove connect files and mobx providers * fix: resolve comments * fix: resolve comment * fix: remove unused files * fix: fix types * fix: resolve comments * fix: resolve comments * fix: snoarcloud * fix: comment * fix: comment * fix: resolve comment * fix: add onclick to test * fix: reset with master * fix: resolve comment --------- Co-authored-by: Matin shafiei <matin@binary.com> Co-authored-by: “Matin-deriv” <matin@deriv.com>
nada-deriv
pushed a commit
that referenced
this pull request
Jan 10, 2024
* fix: delete export from ButtonGroup * feat: add TradeModal * feat: add some data * feat: add test button * feat: add images and some styles * refactor: delete comments * feat: add onClick for CFDs open modal button * feat: almost done * feat: almost done * refactor: delete helper code from TradersHubRoute * feat: implemet review suggestions * feat: implement more comments * feat: change mt5 to CFDPlatforms * feat: implement comments 3 * feat: change Text size * feat: implement comments #4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ui changes for flexible order time selection => dropdown in create/edit ad, new modal onclicking info icon
Screenshots:
Please provide some screenshots of the change.
